feat: added basic components for form toggling #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jadeallencook
commented
Nov 26, 2023
•
jadeallencook
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A1Liu
approved these changes
Nov 30, 2023
src/forms/FormStatusForm/index.tsx
Outdated
Comment on lines
7
to
15
| const [status, setStatus] = useState<boolean>(false); | ||
|
|
||
| const { requestFormStatus, hasFetchedRequestFormStatus } = useContext( | ||
| RequestFormStatusContext | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| setStatus(requestFormStatus); | ||
| }, [requestFormStatus]); |
There was a problem hiding this comment.
Same here, useQuery cached based on the key field so you can just query multiple times and it should only send 1 request; I think you then wouldn't need to use context at all
There was a problem hiding this comment.
Was able to useQuery in the FormStatusForm component, but the AidRequestPage was giving me this error:
FirebaseError: Firebase: Need to provide options, when not being deployed to hosting via source. (app/no-options)
I'm going to move forward with my current changes, and either we can address this later or create a guideline to follow this pattern in the next release.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.