Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix validation workflow #40

Merged
merged 20 commits into from
Jun 29, 2024
Merged

Fix validation workflow #40

merged 20 commits into from
Jun 29, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 29, 2024 •
edited
Loading

Which problem is this PR solving?

  • Workflow wasn't running on PRs because it had the wrong file name for the workflow

Description of the changes

  • Fix the name
  • Allow pushing to a local registry when running from PR
  • Use image from local registry to verify protobuf builds in jaeger and jaeger-idl repos

How was this change tested?

  • CI

yurishkuro added 20 commits June 29, 2024 00:25
@yurishkuro
Fix file name in workflow filter
af3bda4 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
44e9379 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
c3fc6fe 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
5e000c9 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
a762706 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
b64754e 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
ed16d78 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
53b265c 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
92eb118 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
a825762 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
e3d0207 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
d5c9216 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
5480205 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
096c1ff 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
f4a15fb 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
bcee2eb 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
cf957b3 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
6d20c82 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
test
122660c 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
ea16875 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Fix file name in workflow filter Fix validation workflow Jun 29, 2024
@yurishkuro yurishkuro merged commit 20742e7 into main Jun 29, 2024
2 checks passed
@yurishkuro yurishkuro deleted the add-validation2 branch June 29, 2024 21:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro