Do not strip leading zeros from span IDs

jaegertracing · Jan 29, 2021 · 7ac480b · 7ac480b
1 parent 540f6a1
commit 7ac480b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/jaegertracing/SpanContext.h b/src/jaegertracing/SpanContext.h
@@ -156,8 +156,9 @@ class SpanContext : public opentracing::SpanContext {
     void print(Stream& out) const
     {
         _traceID.print(out);
-        out << ':' << std::hex << _spanID << ':' << std::hex << _parentID << ':'
-            << std::hex << static_cast<size_t>(_flags);
+        out << ':' << std::setw(16) << std::setfill('0') << std::hex << _spanID
+            << ':' << std::setw(16) << std::setfill('0') << std::hex << _parentID
+            << ':' << std::hex << static_cast<size_t>(_flags);
     }
 
     void ForeachBaggageItem(

diff --git a/src/jaegertracing/SpanContextTest.cpp b/src/jaegertracing/SpanContextTest.cpp
@@ -78,7 +78,7 @@ TEST(SpanContext, testFormatting)
     SpanContext spanContext(TraceID(255, 255), 0, 0, 0, SpanContext::StrMap());
     std::ostringstream oss;
     oss << spanContext;
-    ASSERT_EQ("00000000000000ff00000000000000ff:0:0:0", oss.str());
+    ASSERT_EQ("00000000000000ff00000000000000ff:0000000000000000:0000000000000000:0", oss.str());
 }
 
 TEST(SpanContext, testBaggage)