Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

localIP: try resolving local hostname first #130

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

tudor
Copy link
Contributor

@tudor tudor commented Sep 13, 2018

Fixes #129.

Signed-off-by: Tudor Bosman tudor@rockset.com

Which problem is this PR solving?

Short description of the changes

  • Just like the Jaeger Java client does, resolve the local hostname in order to determine the local IP address (to populate the "ip" tracer tag with).

Fixes jaegertracing#129.

Signed-off-by: Tudor Bosman <tudor@rockset.com>
@tudor
Copy link
Contributor Author

tudor commented Sep 14, 2018

The test failure seems unrelated:

[ RUN      ]Reporter.testRemoteReporter
/home/travis/build/jaegertracing/jaeger-client-cpp/src/jaegertracing/reporters/ReporterTest.cpp:80: Failure
Expected equality of these values:
  i + 1
    Which is: 72
  spans.size()
    Which is: 71
[  FAILED  ]Reporter.testRemoteReporter (333 ms)

Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change please.

@tudor
Copy link
Contributor Author

tudor commented Sep 17, 2018

Updated to catch (...). PTAL?

Signed-off-by: Tudor Bosman <tudor@rockset.com>
Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@isaachier isaachier merged commit ccd9019 into jaegertracing:master Sep 17, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The C++ Jaeger client always populates the "ip" tag with 127.0.0.1
2 participants