This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Implement SpanContext::Clone #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meastman looks good. Travis CI has this error: Try including |
isaachier
reviewed
Nov 21, 2018
| @@ -164,6 +164,12 @@ class SpanContext : public opentracing::SpanContext { | |||
| forEachBaggageItem(f); | |||
| } | |||
|
|
|||
| std::unique_ptr<opentracing::SpanContext> Clone() const noexcept | |||
| { | |||
There was a problem hiding this comment.
Can you add a lock guard here please:
std::lock_guard<std::mutex> lock(_mutex);
This was added to the opentracing API in opentracing/opentracing-cpp#56 Signed-off-by: Matt Eastman <matt@meastman.org>
Added. |
isaachier
approved these changes
Nov 21, 2018
Thanks for the quick review! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was method added to the opentracing API as a pure virtual method in opentracing/opentracing-cpp#56. Without implementing this method, the jaeger client library cannot be used with recent (post-August-2018) versions of opentracing.