Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add details on how to set agent & collector endpoints #153

Merged

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Resolves #122

Short description of the changes

Adds details on how to set the agent host:port and the collector URL in the README.

Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but leave it up to @yurishkuro.

@isaachier isaachier requested a review from yurishkuro April 3, 2019 23:16
Addresses jaegertracing#122 by adding details on how to set the agent host:port and
the collector URL in the README.

Signed-off-by: Mike Goldsmith <goldsmith.mike@gmail.com>
@MikeGoldsmith MikeGoldsmith force-pushed the agent-collector-endpoint-docs branch from ac60c12 to 2df0594 Compare April 5, 2019 13:51
@MikeGoldsmith
Copy link
Contributor Author

@yurishkuro I've applied your suggestions

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro merged commit 4b964a1 into jaegertracing:master Apr 5, 2019
@MikeGoldsmith MikeGoldsmith deleted the agent-collector-endpoint-docs branch April 5, 2019 17:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants