[thrift]: drop stdcxx namespace #239
Conversation
since thrift has dropped support for stdcxx.h that makes jaeger
incompatible with latest thrift and hence jaeger failure:
/home/ideepika/ceph-primary/ceph/src/jaegertracing/jaeger-client-cpp/src/jaegertracing/thrift-gen/agent_types.h:18:10: fatal error: thrift/stdcxx.h: No such file or directory
18 | #include <thrift/stdcxx.h>
| ^~~~~~~~~~~~~~~~~
this change will make jaeger compatible with latest thrift.
see: apache/thrift#1677
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
|
we need to update the version to thrift 0.13.0 in hunter, I didn't have the bandwidth for it right now, maybe someone can do that. |
|
solves: #195 |
|
@mdouaihy @yurishkuro ping :) |
|
✅ Build jaeger-client-cpp 142 completed (commit d47b7a9107 by @ideepika) |
fixes warning: CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272 (message): The package name passed to `find_package_handle_standard_args` (THRIFT) does not match the name of the calling package (thrift). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake/Findthrift.cmake:92 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:63 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
|
✅ Build jaeger-client-cpp 143 completed (commit 3153d0cd8a by @ideepika) |
|
Hi, thanks for this PR. |
👍 yes, I have added it in a separate commit in this PR itself |
|
Hi, |
| # THRIFT_INCLUDE_DIR, where to find THRIFT headers | ||
| # THRIFT_COMPILER, thrift compiler executable | ||
| # THRIFT_FOUND, If false, do not try to use ant | ||
| # thrift_VERSION_STRING, version string of ant if found |
There was a problem hiding this comment.
why is this lower-case change needed?
There was a problem hiding this comment.
fixes warning:
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
The package name passed to find_package_handle_standard_args (THRIFT)
does not match the name of the calling package (thrift). This can lead to
problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.
Call Stack (most recent call first):
cmake/Findthrift.cmake:92 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:63 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.
|
hello, I ll review the change today and get back to you. |
|
It seems like this PR is ready to be merged, no? Click the button? |
|
✅ Build jaeger-client-cpp 250 completed (commit 3049c925ed by @yurishkuro) |
|
@yurishkuro ping! |
ideepika
changed the title
ideepika
changed the title
ideepika
changed the title
|
@yurishkuro are there plan to issue a new release/tag with this thrift update given thrift has a few security issues? We are looking at moving to openTelemetry C++ but we would like to quickly issue security fixes to customers while the port to openTelemetry gets done. If not, we might consider testing with the latest master. |
yurishkuro
changed the title
since thrift has dropped support for stdcxx.h that makes jaeger
incompatible with latest thrift and hence jaeger failure:
/home/ideepika/ceph-primary/ceph/src/jaegertracing/jaeger-client-cpp/src/jaegertracing/thrift-gen/agent_types.h:18:10: fatal error: thrift/stdcxx.h: No such file or directory
18 | #include <thrift/stdcxx.h>
| ^~~~~~~~~~~~~~~~~
this change will make jaeger compatible with latest thrift.
see: apache/thrift#1677
Note: their won't be development and maintenance effort for this project henceforth, please see: https://medium.com/jaegertracing/jaeger-and-opentelemetry-1846f701d9f2