Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Fix bug in localIP and revert change in TR1 tuple definition #31

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

isaachier
Copy link
Contributor

Signed-off-by: Isaac Hier ihier@uber.com

Signed-off-by: Isaac Hier <ihier@uber.com>
@isaachier
Copy link
Contributor Author

Fixes #30.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #31 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   85.48%   85.49%   +<.01%     
==========================================
  Files          93       93              
  Lines        2239     2240       +1     
  Branches      206      206              
==========================================
+ Hits         1914     1915       +1     
  Misses        253      253              
  Partials       72       72
Impacted Files Coverage Δ
src/jaegertracing/net/IPAddress.cpp 94.44% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874aaca...37ab9ef. Read the comment docs.

@isaachier
Copy link
Contributor Author

Thanks @black-adder

@isaachier isaachier merged commit e6f0644 into jaegertracing:master Dec 4, 2017
@isaachier isaachier deleted the local-ip-segfault-fix branch December 10, 2017 14:49
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants