Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Upgrade to jaeger-lib@2.3.0 to fix broken codahale/hdrhistogram dependency #537

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

yurishkuro
Copy link
Member

Fixes #536

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Upgrade jaeger-lib to v2.3.0 to fix broken codahale dependency Upgrade to jaeger-lib@2.3.0 to fix broken codahale/hdrhistogram dependency Sep 24, 2020
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #537 into master will decrease coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   89.23%   88.28%   -0.95%     
==========================================
  Files          61       61              
  Lines        3919     3277     -642     
==========================================
- Hits         3497     2893     -604     
+ Misses        295      257      -38     
  Partials      127      127              
Impacted Files Coverage Δ
internal/baggage/remote/options.go 71.42% <0.00%> (-7.15%) ⬇️
transport/zipkin/http.go 70.37% <0.00%> (-6.11%) ⬇️
testutils/udp_transport.go 52.38% <0.00%> (-5.69%) ⬇️
transport/http.go 79.62% <0.00%> (-4.20%) ⬇️
utils/localip.go 66.66% <0.00%> (-3.93%) ⬇️
utils/http_json.go 66.66% <0.00%> (-3.93%) ⬇️
log/zap/field.go 84.21% <0.00%> (-3.16%) ⬇️
crossdock/client/client.go 72.72% <0.00%> (-2.89%) ⬇️
crossdock/client/trace.go 66.66% <0.00%> (-2.65%) ⬇️
interop.go 66.66% <0.00%> (-2.57%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fe7fe...bf47ba1. Read the comment docs.

@yurishkuro
Copy link
Member Author

codecov is getting weird

@yurishkuro yurishkuro merged commit 1b4c99e into jaegertracing:master Sep 24, 2020
@yurishkuro yurishkuro deleted the upgrade-jaeger-lib-230 branch September 24, 2020 17:40
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella
3 participants