Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Configuration shouldn't keep a reference to a closed sender #684

Closed
ehsavoie opened this issue Feb 12, 2020 · 0 comments · Fixed by #685
Closed

Configuration shouldn't keep a reference to a closed sender #684

ehsavoie opened this issue Feb 12, 2020 · 0 comments · Fixed by #685

Comments

@ehsavoie
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

When reusing a Configuration to create a tracer, if a previous tracer was closed then the sender should be created again as its connections to the agent are closed.

Problem - what in Jaeger blocks you from solving the requirement?

When redeploying an application the produced tracer's sender is failing because the connection should be reopened.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Adding a closed attribute on a sender to resolve it again when creating a new tracer.
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Recreating sender when a sender has been closed.
d4f358d 
Resolves jaegertracing#684
 * Adding a closed attribute on sender
 * Sender configuration is resolving again is sender is closed.

Issue: jaegertracing#684
@ehsavoie ehsavoie mentioned this issue Feb 12, 2020
Merged
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Recreating sender when a sender has been closed.
3c21721 
Resolves jaegertracing#684
 * Adding a closed attribute on sender
 * Sender configuration is resolving again is sender is closed.

Issue: jaegertracing#684
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Creating a new sender when a sender has been closed.
870d8d7 
Resolves jaegertracing#684

* Adding a closed attribute on sender
* Sender configuration is resolving again is sender is closed.

Issue: jaegertracing#684
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This was referenced Feb 12, 2020
Merged
Closed
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Removing cached sender and tracer from Configuration so that a new
69f9659 
instance can be created when the configuration has changed.

Resolves jaegertracing#684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Removing cached sender and tracer from Configuration so that new inst…
b64183a 
…ances will be created from the configuration.

This allows the new instance to be up-to-date with of configuration changes.

Resolves jaegertracing#684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 12, 2020
@ehsavoie
Removing cached sender and tracer from Configuration so that new inst…
0f67468 
…ances will be created from the configuration.

This allows the new instance to be up-to-date with of configuration changes.

Resolves jaegertracing#684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 14, 2020
@ehsavoie
Removing cached sender from Configuration.
82a2686 
This allows the new instance to be up-to-date with of configuration changes.

Resolves jaegertracing#684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie added a commit to ehsavoie/jaeger-client-java that referenced this issue Feb 14, 2020
@ehsavoie
Removing cached sender from Configuration.
cddf198 
This allows the new instance to be up-to-date with of configuration changes.

Resolves jaegertracing#684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
yurishkuro pushed a commit that referenced this issue Feb 17, 2020
@ehsavoie
Remove caching of the Sender in Configuration (#685)
5e81d89 
This allows the new instance to be up-to-date with of configuration changes.

Resolves #684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
pavolloffay pushed a commit that referenced this issue Feb 17, 2020
@ehsavoie
Configuration do not cache sender instance (#686)
1b64ec7 
This allows the new instance to be up-to-date with of configuration changes.

Resolves #684
     * Adding a closed attribute on sender
     * Sender configuration is resolving again is sender is closed.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configuration do not cache sender instance ehsavoie/jaeger-client-java
1 participant
@ehsavoie