This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Do not encode span context in HTTP_HEADERS format #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
============================================
- Coverage 89.78% 88.85% -0.93%
- Complexity 590 595 +5
============================================
Files 70 72 +2
Lines 2164 2199 +35
Branches 284 287 +3
============================================
+ Hits 1943 1954 +11
- Misses 132 153 +21
- Partials 89 92 +3
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jun 26, 2020
| } | ||
|
|
||
| @Test | ||
| public void testExtractSupportEncodedSpanContext() { |
There was a problem hiding this comment.
I think this and next method names should be swapped
We know that string representation of a span context is safe to use in HTTP header. Thus, there is no need to encode it. JS & Go clients already avoid that unnecesserary encoding. This change is backward compatible because all clients unencode span context even if they do not encode it. More pragmatically, a client impacted by this change would already be incompatible with JS & Go clients. Signed-off-by: Clément MATHIEU <clement@unportant.info>
cykl
force-pushed
the
do_not_encode_span_context
branch
from
1c918e7 to
71b3e03
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
String representation of a span context is safe to use in HTTP header. Thus, there is no need to encode it. JS & Go clients
already avoid that unnecessary encoding.
Resolves #720
Short description of the changes
This change is backward compatible because all clients unencode span context even if they do not encode it. More pragmatically, a client impacted by this change would already be incompatible with JS & Go clients.