Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Upgrade okhttp to 4.9.0 #749

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Upgrade okhttp to 4.9.0 #749

merged 1 commit into from
Sep 29, 2020

Conversation

yurishkuro
Copy link
Member

Fixes #748

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge on green.

@yurishkuro
Copy link
Member Author

yurishkuro commented Sep 29, 2020

merge on green.

can we add a bot to do that?

@jpkrohling
Copy link
Collaborator

Look at the jaeger-operator :-) We'll talk about it on this week's meeting, but in short, yes:
https://github.com/jaegertracing/jaeger-operator/blob/master/.github/mergify.yml

Example PR: jaegertracing/jaeger-operator#1219

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #749 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #749      +/-   ##
============================================
- Coverage     89.11%   88.88%   -0.23%     
+ Complexity      605      603       -2     
============================================
  Files            73       73              
  Lines          2259     2259              
  Branches        295      295              
============================================
- Hits           2013     2008       -5     
- Misses          155      159       +4     
- Partials         91       92       +1     
Impacted Files Coverage Δ Complexity Δ
...rtracing/internal/reporters/CompositeReporter.java 71.42% <0.00%> (-28.58%) 6.00% <0.00%> (-1.00%)
...gertracing/internal/reporters/LoggingReporter.java 81.81% <0.00%> (-9.10%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640fa35...cc33621. Read the comment docs.

@yurishkuro yurishkuro merged commit d444df2 into master Sep 29, 2020
@yurishkuro yurishkuro deleted the bump-okhttp-4.9.0-fx-748 branch September 29, 2020 16:43
@pbd-axa
Copy link

pbd-axa commented Nov 4, 2020

May I ask for the next planned version which contains this fix as it is a potenial security risk ?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
3 participants