Skip to content

Commit

Permalink
Upgrade react-icons to v5 without causing test failures. (#2134)
Browse files Browse the repository at this point in the history 
## Which problem is this PR solving?
Resolves #2117 

## Description of the changes
- I have upgraded the react-icons library to v5.0.1 which was earlier
attempted by Dependabot in PR #2116.
- A failing test occurred due to a snapshot mismatch after the upgrade.
I've documented my investigation in the comments of issue #2117. To
prevent any test failures, it is safe to update the existing snapshot.

## How was this change tested?
Using the `yarn test-ci` command in my local setup.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have run lint and test steps successfully

---------

Signed-off-by: Prajjwal <prajjwalyd@gmail.com>
  • Loading branch information
@prajjwalyd
prajjwalyd authored Jan 25, 2024
1 parent 8f31abc commit 81bf7d7
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion packages/jaeger-ui/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"react-circular-progressbar": "^2.1.0",
"react-dom": "^18.2.0",
"react-helmet": "^6.1.0",
"react-icons": "^4.10.1",
"react-icons": "^5.0.1",
"react-is": "^18.2.0",
"react-json-view-lite": "1.2.0",
"react-redux": "^8.1.2",
Expand Down
18 changes: 9 additions & 9 deletions ...rc/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -1197,7 +1197,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -2271,7 +2271,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -3345,7 +3345,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -4419,7 +4419,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -5493,7 +5493,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -6567,7 +6567,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -7641,7 +7641,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down Expand Up @@ -8715,7 +8715,7 @@ Array [
strokeWidth="32"
/>
<path
d="M248 130a26 26 0 1026 26 26 26 0 00-26-26z"
d="M248 130a26 26 0 1 0 26 26 26 26 0 0 0-26-26z"
key="3"
/>
</svg>,
Expand Down
2 changes: 1 addition & 1 deletion packages/plexus/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"d3-zoom": "^3.0.0",
"memoize-one": "6.0.0",
"viz.js": "1.8.1",
"react-icons": "^4.10.1"
"react-icons": "^5.0.1"
},
"scripts": {
"_tasks/build/lib/js": "node_modules/.bin/babel src --extensions '.tsx,.js' --out-dir lib",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8514,10 +8514,10 @@ react-helmet@^6.1.0:
react-fast-compare "^3.1.1"
react-side-effect "^2.1.0"

react-icons@^4.10.1:
version "4.12.0"
resolved "https://registry.yarnpkg.com/react-icons/-/react-icons-4.12.0.tgz#54806159a966961bfd5cdb26e492f4dafd6a8d78"
integrity sha512-IBaDuHiShdZqmfc/TwHu6+d6k2ltNCf3AszxNmjJc1KUfXdEeRJOKyNvLmAHaarhzGmTSVygNdyu8/opXv2gaw==
react-icons@^5.0.1:
version "5.0.1"
resolved "https://registry.yarnpkg.com/react-icons/-/react-icons-5.0.1.tgz#1694e11bfa2a2888cab47dcc30154ce90485feee"
integrity sha512-WqLZJ4bLzlhmsvme6iFdgO8gfZP17rfjYEJ2m9RsZjZ+cc4k1hTzknEz63YS1MeT50kVzoa1Nz36f4BEx+Wigw==

react-is@^16.12.0, react-is@^16.13.1, react-is@^16.4.2, react-is@^16.6.0, react-is@^16.7.0:
version "16.13.1"
Expand Down

0 comments on commit 81bf7d7

Please # to comment.