Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix temp files for depcheck #2133

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

yurishkuro
Copy link
Member

It was creating always the same files on Mac, probably because it requires XXXX to be the end of the pattern.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner January 24, 2024 00:07
@yurishkuro yurishkuro requested review from joe-elliott and removed request for a team January 24, 2024 00:07
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c889b8) 96.57% compared to head (0e8d006) 96.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         254      254           
  Lines        7620     7620           
  Branches     1986     1986           
=======================================
  Hits         7359     7359           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Jan 24, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
albertteoh
albertteoh previously approved these changes Jan 24, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yurishkuro yurishkuro merged commit 8f31abc into jaegertracing:main Jan 24, 2024
10 checks passed
@yurishkuro yurishkuro deleted the remove-html-loader branch January 24, 2024 21:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants