Span Search - Highlight search results

[davit-y]

Which problem is this PR solving?

• Improved Span Search #235

Short description of the changes

• No longer drop opacity of spans that don't match filter
• Highlight those that do

"Highlight matching spans" is the first commit of this branch, PR will be cleaner once #234 is merged

[davit-y]

Screenshots

[codecov]

Codecov Report

Merging #238 into master will decrease coverage by 1.08%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   78.61%   77.53%   -1.09%     
==========================================
  Files         135      135              
  Lines        2927     2933       +6     
  Branches      607      607              
==========================================
- Hits         2301     2274      -27     
- Misses        495      522      +27     
- Partials      131      137       +6

Impacted Files	Coverage Δ
...components/TracePage/TracePageSearchBar.markers.js	100% <ø> (ø)
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js	100% <ø> (ø)	⬆️
...onents/TracePage/TraceTimelineViewer/SpanBarRow.js	80% <ø> (ø)	⬆️
.../components/TracePage/TraceTimelineViewer/index.js	100% <ø> (ø)	⬆️
...c/components/TracePage/TraceTimelineViewer/duck.js	100% <ø> (ø)	⬆️
...-ui/src/components/TracePage/keyboard-shortcuts.js	81.81% <ø> (ø)	⬆️
.../src/components/TracePage/KeyboardShortcutsHelp.js	20% <ø> (-13.34%)	⬇️
...ger-ui/src/components/TracePage/TracePageHeader.js	70% <0%> (-10%)	⬇️
...cePage/TraceTimelineViewer/VirtualizedTraceView.js	93.45% <100%> (-0.41%)	⬇️
...ckages/jaeger-ui/src/components/TracePage/index.js	76.1% <28.57%> (-18.95%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d148dc5...9bb150a. Read the comment docs.

[codecov]

Codecov Report

Merging #238 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   77.05%   77.15%   +0.09%     
==========================================
  Files         135      135              
  Lines        2951     2950       -1     
  Branches      614      613       -1     
==========================================
+ Hits         2274     2276       +2     
+ Misses        534      531       -3     
  Partials      143      143

Impacted Files	Coverage Δ
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js	100% <ø> (ø)	⬆️
...onents/TracePage/TraceTimelineViewer/SpanBarRow.js	80% <ø> (ø)	⬆️
...cePage/TraceTimelineViewer/VirtualizedTraceView.js	93.45% <100%> (-0.07%)	⬇️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js	92.59% <0%> (+5.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35841f7...fc115eb. Read the comment docs.

[tiffon]

Great work!

[cptkng23]

Hi @davit-y , @tiffon
I'm trying to understand how this highlighting of search results works. I'm using latest version (1.22 all-in-one), but when I click on any Trace that is displayed after a search with certain Tags, I cannot find a "highlighted" Span in the Trace detail view.

Could you explain how this is supposed to work, or maybe point me to some documentation. Maybe I missed to configure something properly, but I wasn't able to find anything related to that on any of the pages here: https://www.jaegertracing.io/docs/1.22/