Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Address new warnings from the linter upgrade #5585

Closed
yurishkuro opened this issue Jun 12, 2024 · 0 comments · Fixed by #5589
Closed

Address new warnings from the linter upgrade #5585

yurishkuro opened this issue Jun 12, 2024 · 0 comments · Fixed by #5589
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Per #5579 (comment)

$ make install-tools lint
...
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.
WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.
WARN [config_reader] The configuration option `linters.gosimple.go` is deprecated, please use global `run.go`.
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jun 12, 2024
@WaterLemons2k WaterLemons2k mentioned this issue Jun 12, 2024
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Jun 12, 2024
@WaterLemons2k
Fix new warnings from the linter upgrade (#5589)
0c8e025 
## Which problem is this PR solving?
- Resolves #5585

## Description of the changes
Fix new warnings from the `golangci-lint` linter upgrade.

## How was this change tested?

The configuration has been verified with the command `golangci-lint
config verify`.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---

These warnings came from:
https://github.com/golangci/golangci-lint/blob/master/pkg/config/loader.go#L374

Signed-off-by: Shane Sun <62788816+WaterLemons2k@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix new warnings from the linter upgrade
1 participant
@yurishkuro