Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make rollover idempotent #1407

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

pavolloffay
Copy link
Member

Resolves #1403

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Python, but other than that, looks sane to me.

@pavolloffay
Copy link
Member Author

I am happy that it's not ruby 💩

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #1407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1407   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         164     164           
  Lines        7502    7502           
======================================
  Hits         7502    7502

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb23a4...6900f6a. Read the comment docs.

@pavolloffay pavolloffay merged commit de975e3 into jaegertracing:master Mar 6, 2019
@ghost ghost removed the review label Mar 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants