Copy spans from memory store, fixes #2719 #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
ivan/clear-warnings
branch
from
c6014e9 to
59ef162
Compare
Codecov Report
@@ Coverage Diff @@
## master #2720 +/- ##
==========================================
+ Coverage 95.73% 95.74% +0.01%
==========================================
Files 216 216
Lines 9593 9599 +6
==========================================
+ Hits 9184 9191 +7
Misses 336 336
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 8, 2021
bobrik
force-pushed
the
ivan/clear-warnings
branch
from
59ef162 to
7b980eb
Compare
Copying allows spans to be freely modified by adjusters and any other code without accidentally altering what is stored in the in-memory store itself. Signed-off-by: Ivan Babrou <github@ivan.computer>
bobrik
force-pushed
the
ivan/clear-warnings
branch
from
7b980eb to
f38fe25
Compare
yurishkuro
previously approved these changes
Jan 9, 2021
|
any way to raise the test coverage? It's probably red in the new error handling places. |
|
Any suggestions on how to approach this? I can't figure out how to trick |
|
The following results in an error: |
Signed-off-by: Ivan Babrou <github@ivan.computer>
bobrik
force-pushed
the
ivan/clear-warnings
branch
from
b5f2a57 to
cfb05ac
Compare
mergify
bot
dismissed
yurishkuro’s stale review
Pull request has been modified.
|
Added a commit with two more tests to test this scenario, thanks! |
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
…usters (jaegertracing#2720) * Copy spans from memory store, fixes jaegertracing#2719 Copying allows spans to be freely modified by adjusters and any other code without accidentally altering what is stored in the in-memory store itself. Signed-off-by: Ivan Babrou <github@ivan.computer> * Add tests to exercise the broken serialization path Signed-off-by: Ivan Babrou <github@ivan.computer>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying allows spans to be freely modified by adjusters and any other code without accidentally altering what is stored in the in-memory store itself. Resolves #2719.