-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use fork of Apache Thrift #2780
Use fork of Apache Thrift #2780
Conversation
@jpkrohling Would be good to create an issue to revert the change once an official version is available, and link within the description of this PR. |
Codecov Report
@@ Coverage Diff @@
## master #2780 +/- ##
==========================================
+ Coverage 95.89% 95.90% +0.01%
==========================================
Files 217 217
Lines 9625 9625
==========================================
+ Hits 9230 9231 +1
Misses 326 326
+ Partials 69 68 -1
Continue to review full report at Codecov.
|
@Mario-Hofstaetter, @zigmund, would you be open to testing an image with this PR, to confirm that your problems will get fixed? |
@jpkrohling Will do, hope to get it done by friday. |
I thought we wanted the fork to be in github.com/jaegertracing. Why use personal fork? |
I can push my fork to the jaegertracing organization, but it makes that somewhat too "official". I really want this to be temporary. |
We can reflect that in the forked repo description. Btw pushing to a new repo from yours will not establish the forked link on GitHub. |
@jpkrohling yes, I can test image in few days. |
Yes, sorry, I meant that I would fork Apache Thrift to jaegertracing org and push the tag there. |
PR updated to use the fork from the jaegertracing organization. |
Temporarily use a personal fork of Apache Thrift, tagged with 1.13.1, which includes the fix for THRIFT-5322 (apache/thrift#2292). Fixes #2638 and #2452. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Temporarily use a personal fork of Apache Thrift, tagged with 1.13.1, which includes the fix for THRIFT-5322 (apache/thrift#2292).
Fixes #2638 and fixes #2452.
The issue to track the reversion of this PR is #2781.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de