Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docker images for linux/arm64 #3124

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

GaruGaru
Copy link
Contributor

@GaruGaru GaruGaru commented Jul 4, 2021

Signed-off-by: Tommaso Garuglieri garuglieritommaso.dev@gmail.com

Which problem is this PR solving?

Running jaeger on linux/arm64, Related to #2292 and #2176

Short description of the changes

@GaruGaru GaruGaru requested a review from a team as a code owner July 4, 2021 15:47
@GaruGaru GaruGaru requested a review from joe-elliott July 4, 2021 15:48
Signed-off-by: Tommaso Garuglieri <garuglieritommaso.dev@gmail.com>

Signed-off-by: GaruGaru <garuglieritommaso.dev@gmail.com>
@GaruGaru GaruGaru force-pushed the docker-images-arm64 branch from c96bb23 to e5395d9 Compare July 4, 2021 15:48
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #3124 (d653218) into master (23b5b66) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3124      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.02%     
==========================================
  Files         236      236              
  Lines       10238    10238              
==========================================
+ Hits         9817     9820       +3     
+ Misses        349      348       -1     
+ Partials       72       70       -2     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.20% <0.00%> (-2.60%) ⬇️
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
cmd/query/app/server.go 97.22% <0.00%> (+1.38%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b5b66...d653218. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be nice to get approval from @kun-lu20 or @Ashmita152 as well.

@Ashmita152
Copy link
Contributor

Thank you for the PR. It looks good to me.

@jpkrohling jpkrohling enabled auto-merge (squash) July 5, 2021 09:56
@jpkrohling jpkrohling merged commit 7a83219 into jaegertracing:master Jul 5, 2021
denisazevedo added a commit to denisazevedo/aws-graviton-getting-started that referenced this pull request Dec 31, 2021
Jaeger is already set with the multi-arch build since this [pull request](jaegertracing/jaeger#3124).
AGSaidi pushed a commit to aws/aws-graviton-getting-started that referenced this pull request Feb 1, 2022
Jaeger is already set with the multi-arch build since this [pull request](jaegertracing/jaeger#3124).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants