Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add /api prefix for /v3 API #3178

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Implementation for jaegertracing/jaeger-idl#82

@pavolloffay pavolloffay requested a review from a team as a code owner August 4, 2021 09:49
@pavolloffay pavolloffay requested a review from albertteoh August 4, 2021 09:49
jpkrohling
jpkrohling previously approved these changes Aug 4, 2021
@jpkrohling jpkrohling enabled auto-merge (squash) August 4, 2021 09:53
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #3178 (6e516d9) into master (6eb9490) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   95.93%   95.96%   +0.03%     
==========================================
  Files         239      239              
  Lines       14649    14649              
==========================================
+ Hits        14053    14058       +5     
+ Misses        518      515       -3     
+ Partials       78       76       -2     
Impacted Files Coverage Δ
cmd/query/app/apiv3/grpc_gateway.go 86.95% <100.00%> (ø)
plugin/storage/integration/integration.go 78.88% <0.00%> (-0.40%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb9490...6e516d9. Read the comment docs.

yurishkuro
yurishkuro previously approved these changes Aug 4, 2021
@pavolloffay
Copy link
Member Author

The CI is failing due to #3179

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay merged commit 4ad17c5 into jaegertracing:master Aug 4, 2021
@vprithvi vprithvi added this to the Release 1.25.0 milestone Aug 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants