Fix panic on empty findTraces query #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <alexmkuznicki@gmail.com>
… fix-SIGSEGV-2996
jpkrohling
previously approved these changes
Aug 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #3232 +/- ##
==========================================
- Coverage 95.99% 95.99% -0.01%
==========================================
Files 242 242
Lines 14789 14813 +24
==========================================
+ Hits 14197 14219 +22
- Misses 513 515 +2
Partials 79 79
Continue to review full report at Codecov.
|
|
@akuzni2, do you think you can improve the test coverage of this PR? |
Signed-off-by: Alex <alexmkuznicki@gmail.com>
…into fix-SIGSEGV-2996 � Conflicts: � cmd/query/app/grpc_handler_test.go
@jpkrohling - Thanks for reviewing! updated tests to meet code cov for the file which was changed Not sure why the Codecov report is showing my changes impacted the other files |
Signed-off-by: Alex <alexmkuznicki@gmail.com>
jpkrohling
approved these changes
Aug 26, 2021
jpkrohling
approved these changes
Aug 26, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #2996
Short description of the changes
Added validation checks to the gRPC server handler methods that implement the QueryServiceClient interface.
Couple of notes:
nil- however the client looks like it panics before it reaches the server. Is there a way I can write a unit test for this functionality? As I understand it perhaps not all clients generated in other languages python, java, javascript etc... would fail before sending request to the server.GetServicesservice method: the request parameterr *api_v2.GetServicesRequestnot used so I didn't add any validation for it.Questions for the following service methods
GetOperationsGetOperationsRequestparameters are Service and Span which are typeString. Not sure what the behavior should be if they are"". Is it possible that these are valid arguments?