Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add 'opensearch' as a supported value for SPAN_STORAGE_TYPE #3255

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

yurishkuro
Copy link
Member

Resolves #3247

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 9, 2021 18:13
@yurishkuro yurishkuro changed the title Add 'opensearch' as a supported value for SPAN_STORAGE_TYPE WIP Add 'opensearch' as a supported value for SPAN_STORAGE_TYPE Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #3255 (75c331f) into master (b5d340d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   95.84%   95.85%           
=======================================
  Files         259      259           
  Lines       15398    15398           
=======================================
+ Hits        14758    14759    +1     
  Misses        550      550           
+ Partials       90       89    -1     
Impacted Files Coverage Δ
plugin/storage/factory_config.go 100.00% <ø> (ø)
plugin/storage/factory.go 94.47% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
plugin/storage/badger/spanstore/reader.go 95.50% <0.00%> (-0.71%) ⬇️
cmd/query/app/server.go 95.58% <0.00%> (+1.47%) ⬆️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d340d...75c331f. Read the comment docs.

@yurishkuro yurishkuro changed the title WIP Add 'opensearch' as a supported value for SPAN_STORAGE_TYPE Add 'opensearch' as a supported value for SPAN_STORAGE_TYPE Sep 9, 2021
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yurishkuro yurishkuro merged commit 17da056 into jaegertracing:master Sep 10, 2021
@yurishkuro yurishkuro deleted the opensearch branch September 10, 2021 13:32
@jpkrohling jpkrohling added this to the v1.27.0 milestone Sep 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should opensearch be a recognized backend type?
4 participants