-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update monitoring mixin #3331
Update monitoring mixin #3331
Conversation
@gouthamve, as the original author of this mixin, would you like to review it? |
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 96.01% 95.96% -0.06%
==========================================
Files 259 259
Lines 15434 15434
==========================================
- Hits 14819 14811 -8
- Misses 522 528 +6
- Partials 93 95 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jaegertracing/jaeger-maintainers , would one of you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of suggestions.
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Closes #2956
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de