Remove unused method GetProbabilitiesAndQPS from samplingstore
#3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
yurishkuro
previously approved these changes
Oct 24, 2021
Signed-off-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
auto-merge was automatically disabled
October 24, 2021 23:08
Head branch was pushed to by a user without write access
yurishkuro
approved these changes
Oct 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #3339 +/- ##
=======================================
Coverage 95.98% 95.99%
=======================================
Files 259 259
Lines 15434 15422 -12
=======================================
- Hits 14815 14805 -10
+ Misses 525 524 -1
+ Partials 94 93 -1
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Srikanth Chekuri srikanth.chekuri92@gmail.com
Which problem is this PR solving?
Based on this comment on other related PR #3335 (comment)