Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove outdated reference to cover.sh #3348

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove outdated reference to cover.sh #3348

merged 1 commit into from
Oct 28, 2021

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Oct 28, 2021 •
edited by yurishkuro
Loading

Which problem is this PR solving?

@rbroggi rbroggi requested a review from a team as a code owner October 28, 2021 19:15
@rbroggi rbroggi requested a review from albertteoh October 28, 2021 19:15
@rbroggi
jaegertracing#3347 removing outdated session
fcf81d0 
Signed-off-by: rbroggi <ro_broggi@hotmail.com>
@rbroggi rbroggi force-pushed the 3347-contributing-update branch from ef2410d to fcf81d0 Compare October 28, 2021 19:15
@yurishkuro yurishkuro changed the title #3347 removing outdated session in CONTRIBUTING.md Remove outdated reference to cover.sh Oct 28, 2021
yurishkuro
yurishkuro approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro enabled auto-merge (squash) October 28, 2021 19:24
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #3348 (fcf81d0) into master (e9bf6ed) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
+ Coverage   95.97%   95.99%   +0.01%     
==========================================
  Files         261      261              
  Lines       15464    15464              
==========================================
+ Hits        14842    14844       +2     
+ Misses        528      526       -2     
  Partials       94       94
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
plugin/storage/integration/integration.go 79.28% <0.00%> (+0.39%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bf6ed...fcf81d0. Read the comment docs.

@yurishkuro yurishkuro merged commit 8b7772e into jaegertracing:master Oct 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh was automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated CONTRIBUTING.md
2 participants
@rbroggi @yurishkuro