Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix race condition when adding collector tags #3886

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

yurishkuro
Copy link
Member

Hopefully resolves #3885

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner August 25, 2022 15:36
@yurishkuro yurishkuro requested a review from vprithvi August 25, 2022 15:36
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 97.61% // Head: 97.63% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4a950c3) compared to base (1c97af0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3886      +/-   ##
==========================================
+ Coverage   97.61%   97.63%   +0.01%     
==========================================
  Files         293      293              
  Lines       17064    17070       +6     
==========================================
+ Hits        16657    16666       +9     
+ Misses        321      319       -2     
+ Partials       86       85       -1     
Impacted Files Coverage Δ
cmd/collector/app/span_processor.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 98.19% <0.00%> (+1.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 538d96c into jaegertracing:main Aug 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Panic of jaeger collector
1 participant