fix: streaming span writer is not working in grpc based remote storage plugin #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugin Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
grpc_handler.go handles only io.EOF and skipping other errors causes crash. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
force-pushed
the
grpc-remote-streaming-plugin
branch
from
a2807b7 to
7551b95
Compare
|
cc @yurishkuro |
yurishkuro
approved these changes
Aug 26, 2022
Codecov ReportBase: 97.63% // Head: 97.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 293 293
Lines 17070 17073 +3
=======================================
+ Hits 16666 16669 +3
Misses 319 319
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?