Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug] Fix syntax for invoking upload-codecov action #5416

Merged
merged 1 commit into from
May 5, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Noticed the following logs, not sure how it worked (probably default matched the file name)
Unexpected input(s) 'file', valid inputs are ['files', 'flags']

Description of the changes

  • Change calls to this action to always specify files param

How was this change tested?

  • CI

Checklist

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner May 5, 2024 05:01
@yurishkuro yurishkuro requested a review from jkowall May 5, 2024 05:01
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (4fed4f4) to head (c7b6a0e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5416   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files         346      346           
  Lines       16954    16954           
=======================================
  Hits        16035    16035           
  Misses        717      717           
  Partials      202      202           
Flag Coverage Δ
badger_v1 10.28% <ø> (ø)
badger_v2 6.56% <ø> (-0.04%) ⬇️
cassandra-3.x-v1 18.12% <ø> (ø)
cassandra-3.x-v2 6.31% <ø> (ø)
cassandra-4.x-v1 18.12% <ø> (ø)
cassandra-4.x-v2 6.29% <ø> (ø)
elasticsearch-5.x 5.89% <ø> (ø)
elasticsearch-6.x 5.89% <ø> (-0.02%) ⬇️
elasticsearch-7.x 5.90% <ø> (+0.01%) ⬆️
elasticsearch-8.x 5.89% <ø> (-0.02%) ⬇️
grpc_v1 12.57% <ø> (-0.04%) ⬇️
grpc_v2 11.52% <ø> (ø)
kafka 9.95% <ø> (ø)
opensearch-1.x 5.90% <ø> (ø)
opensearch-2.x 5.90% <ø> (ø)
unittests 91.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 2bb3d01 into jaegertracing:main May 5, 2024
40 of 41 checks passed
@yurishkuro yurishkuro deleted the fix-codecov-usage branch May 5, 2024 07:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants