Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[refactor] move root span handler into aggregator #5478

Merged
merged 6 commits into from
May 26, 2024

Conversation

Pushkarm029
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Refactored handleRootSpan logic into a helper method in aggregator.go.

How was this change tested?

  • not tested

Checklist

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 requested a review from a team as a code owner May 23, 2024 07:05
@Pushkarm029 Pushkarm029 requested a review from jkowall May 23, 2024 07:05
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (901165c) to head (143fc0c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5478      +/-   ##
==========================================
+ Coverage   95.52%   95.53%   +0.01%     
==========================================
  Files         331      330       -1     
  Lines       16155    16156       +1     
==========================================
+ Hits        15432    15435       +3     
+ Misses        548      547       -1     
+ Partials      175      174       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x ?
elasticsearch-8.x ?
grpc_v1 9.51% <ø> (-0.02%) ⬇️
grpc_v2 7.58% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1.x 1.78% <ø> (+0.01%) ⬆️
opensearch-2.x 1.78% <ø> (ø)
unittests 93.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 changed the title Refactor handleRootSpan logic into a helper function Implement the logic of handleRootSpan into an aggregator function. May 25, 2024
Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 changed the title Implement the logic of handleRootSpan into an aggregator function. Refactor the logic of handleRootSpan into an aggregator function. May 26, 2024
@yurishkuro yurishkuro changed the title Refactor the logic of handleRootSpan into an aggregator function. [refactor] move root span handler into aggregator May 26, 2024
@yurishkuro yurishkuro merged commit a194bd9 into jaegertracing:main May 26, 2024
36 of 39 checks passed
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request Jun 2, 2024
## Which problem is this PR solving?
-
jaegertracing#5389 (comment)

## Description of the changes
- Refactored `handleRootSpan` logic into a helper method in
aggregator.go.


Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants