Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Lint Rule: dot-imports #5513

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Enabled dot-imports in revive linter.
  • Removed dot imports in a few and added qualifiers for the rest.

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 3, 2024 04:08
@FlamingSaint FlamingSaint requested a review from pavolloffay June 3, 2024 04:08
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (c428138) to head (8191513).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5513       +/-   ##
===========================================
+ Coverage   54.23%   96.18%   +41.94%     
===========================================
  Files         161      327      +166     
  Lines        8369    16012     +7643     
===========================================
+ Hits         4539    15401    +10862     
+ Misses       3384      436     -2948     
+ Partials      446      175      -271     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7-v1 18.88% <ø> (-0.02%) ⬇️
elasticsearch-8-v1 19.08% <ø> (ø)
elasticsearch-8-v2 19.07% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1-v1 18.94% <ø> (ø)
opensearch-2-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2-v2 18.92% <ø> (-0.02%) ⬇️
unittests 93.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 3, 2024
@yurishkuro yurishkuro merged commit 3f82224 into jaegertracing:main Jun 3, 2024
40 of 41 checks passed
@FlamingSaint FlamingSaint deleted the lint-rules branch June 3, 2024 21:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants