Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Lint Rule: unused-parameter #5534

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

FlamingSaint
Copy link
Member

@FlamingSaint FlamingSaint commented Jun 5, 2024

Which problem is this PR solving?

Description of the changes

  • Enabled unused-parameter in revive linter
  • Removed or replaced unused parameters with ( _ )
  • Added comments for unclear parameters

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 5, 2024 01:07
@FlamingSaint FlamingSaint requested a review from joe-elliott June 5, 2024 01:07
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.20%. Comparing base (52473e7) to head (40a1934).

Files Patch % Lines
cmd/collector/app/server/test.go 50.00% 1 Missing ⚠️
pkg/discovery/grpcresolver/grpc_resolver.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5534   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         327      327           
  Lines       16007    16007           
=======================================
  Hits        15399    15399           
  Misses        432      432           
  Partials      176      176           
Flag Coverage Δ
badger_v1 8.05% <11.86%> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-3.x-v1 16.45% <25.42%> (ø)
cassandra-3.x-v2 1.85% <0.00%> (ø)
cassandra-4.x-v1 16.45% <25.42%> (ø)
cassandra-4.x-v2 1.85% <0.00%> (ø)
elasticsearch-7-v1 18.88% <8.47%> (-0.02%) ⬇️
elasticsearch-8-v1 19.07% <10.16%> (-0.02%) ⬇️
elasticsearch-8-v2 19.07% <10.16%> (-0.02%) ⬇️
grpc_v1 9.47% <5.08%> (ø)
grpc_v2 7.53% <5.08%> (ø)
kafka 9.77% <10.16%> (ø)
opensearch-1-v1 18.93% <8.47%> (-0.02%) ⬇️
opensearch-2-v1 18.94% <8.47%> (ø)
opensearch-2-v2 18.94% <8.47%> (ø)
unittests 94.07% <94.87%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from yurishkuro June 5, 2024 03:52
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 5, 2024
@FlamingSaint FlamingSaint requested a review from yurishkuro June 6, 2024 00:46
@yurishkuro yurishkuro merged commit 3d4b6b6 into jaegertracing:main Jun 7, 2024
40 checks passed
@FlamingSaint FlamingSaint deleted the linter_5 branch June 17, 2024 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants