-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create config file for Mockery instead of using explicit CLI flags in the Makefile #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please make sure all commits are signed |
Signed-off-by: jessica lourenco <jess.mailed@gmail.com> Signed-off-by: jesslourenco <70455379+jesslourenco@users.noreply.github.com>
127eef9
to
6852488
Compare
yurishkuro
reviewed
Jun 13, 2024
yurishkuro
reviewed
Jun 13, 2024
- Updated target in makefile Signed-off-by: jesslourenco <70455379+jesslourenco@users.noreply.github.com>
…nstead of Mock<Interfacename> - removed custom rules for es/client in mockery config since they are no longer necessary Signed-off-by: jesslourenco <70455379+jesslourenco@users.noreply.github.com>
yurishkuro
reviewed
Jun 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5623 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.02%
==========================================
Files 327 327
Lines 16014 16014
==========================================
- Hits 15406 15404 -2
- Misses 432 433 +1
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Jun 13, 2024
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
make generate-mocks
client
. These files are still (auto) generated but within es/client/mocks onlyHow was this change tested?
mockery
make test
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test