Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleanup the Prometheus config #5720

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Cleaned up the Prometheus config
  • Removed namespaceConfig as its not needed for a metrics storage

How was this change tested?

  • make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (ea2ec18) to head (5903ef0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5720      +/-   ##
==========================================
- Coverage   96.89%   96.87%   -0.02%     
==========================================
  Files         334      334              
  Lines       16146    16141       -5     
==========================================
- Hits        15644    15637       -7     
- Misses        333      334       +1     
- Partials      169      170       +1     
Flag Coverage Δ
badger_v1 8.06% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.80% <ø> (ø)
elasticsearch-7.x-v1 18.86% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.04% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.89% <ø> (-0.02%) ⬇️
grpc_v1 9.46% <ø> (ø)
grpc_v2 7.41% <ø> (ø)
kafka 9.75% <ø> (ø)
opensearch-1.x-v1 18.91% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.90% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.90% <ø> (ø)
unittests 95.26% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FlamingSaint and others added 2 commits July 8, 2024 22:14
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from yurishkuro July 8, 2024 16:58
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@yurishkuro yurishkuro merged commit 295293c into jaegertracing:main Jul 8, 2024
42 checks passed
@FlamingSaint FlamingSaint deleted the config-cleanup branch July 8, 2024 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants