Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Completely remove "grpc-plugin" as storage type #5741

Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 14, 2024

Which problem is this PR solving?

Description of the changes

  • No longer accept grpc-plugin as a storage type. The valid value is grpc.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label Jul 14, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner July 14, 2024 03:21
@yurishkuro yurishkuro requested a review from jkowall July 14, 2024 03:21
@dosubot dosubot bot added the area/storage label Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (e3e763c) to head (3e95bea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5741      +/-   ##
==========================================
+ Coverage   96.84%   96.89%   +0.04%     
==========================================
  Files         335      335              
  Lines       16166    16160       -6     
==========================================
+ Hits        15656    15658       +2     
+ Misses        340      334       -6     
+ Partials      170      168       -2     
Flag Coverage Δ
badger_v1 8.05% <ø> (+<0.01%) ⬆️
badger_v2 ?
cassandra-3.x-v1 16.61% <ø> (+0.01%) ⬆️
cassandra-3.x-v2 1.82% <ø> (+<0.01%) ⬆️
cassandra-4.x-v1 16.61% <ø> (+0.01%) ⬆️
cassandra-4.x-v2 ?
elasticsearch-6.x-v1 18.79% <ø> (+0.01%) ⬆️
elasticsearch-7.x-v1 18.85% <ø> (+0.02%) ⬆️
elasticsearch-8.x-v1 19.03% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.90% <ø> (+<0.01%) ⬆️
grpc_v1 9.51% <ø> (-0.01%) ⬇️
grpc_v2 ?
kafka 9.74% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.90% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.90% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.90% <ø> (+0.01%) ⬆️
unittests 95.28% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 023d46e into jaegertracing:main Jul 14, 2024
44 checks passed
@yurishkuro yurishkuro deleted the remove-grpc-plugin-storage-type branch July 14, 2024 03:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/storage changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants