[jaeger-v2] Consolidate v1 and v2 Configurations for GRPC Storage #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6042 +/- ##
==========================================
- Coverage 96.92% 96.90% -0.02%
==========================================
Files 349 349
Lines 16600 16587 -13
==========================================
- Hits 16089 16074 -15
- Misses 328 329 +1
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Oct 4, 2024
yurishkuro
added
the
changelog:exprimental
|
lgtm |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
|
@yurishkuro I don't believe this is a breaking change because the v1 config was being translated to v2 which is what was being used. Let me know if that's incorrect. |
yurishkuro
reviewed
Oct 4, 2024
| @@ -113,15 +113,15 @@ func TestNewFactoryError(t *testing.T) { | |||
| t.Run("viper", func(t *testing.T) { | |||
| f := NewFactory() | |||
| f.InitFromViper(viper.New(), zap.NewNop()) | |||
| f.configV2 = cfg | |||
| f.config = *cfg | |||
There was a problem hiding this comment.
remove & from declaration and * from here
yurishkuro
approved these changes
Oct 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test