Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][query] Correct query server legacy condition #6120

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 25, 2024 01:53
@mahadzaryab1 mahadzaryab1 changed the title [fix][jaeger-v2] Correct query server legacy condition [fix][query] Correct query server legacy condition Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (2fbc067) to head (651b78b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6120      +/-   ##
==========================================
- Coverage   96.46%   96.42%   -0.04%     
==========================================
  Files         352      352              
  Lines       20007    20007              
==========================================
- Hits        19300    19292       -8     
- Misses        524      531       +7     
- Partials      183      184       +1     
Flag Coverage Δ
badger_v1 8.42% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1 14.57% <ø> (ø)
cassandra-4.x-v2 1.64% <ø> (ø)
cassandra-5.x-v1 14.57% <ø> (ø)
cassandra-5.x-v2 1.64% <ø> (ø)
elasticsearch-6.x-v1 18.73% <ø> (ø)
elasticsearch-7.x-v1 18.81% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 18.97% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.70% <ø> (+0.01%) ⬆️
grpc_v1 8.77% <ø> (ø)
grpc_v2 6.71% <ø> (-0.02%) ⬇️
kafka-v1 8.99% <ø> (ø)
kafka-v2 1.70% <ø> (ø)
memory_v2 1.70% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.86% <ø> (ø)
opensearch-2.x-v1 18.86% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.69% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.34% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!

@yurishkuro yurishkuro merged commit 9f4e8f7 into jaegertracing:main Oct 25, 2024
49 of 52 checks passed
@yurishkuro
Copy link
Member

kinda sad that no tests caught this

yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
@mahadzaryab1 mahadzaryab1 deleted the fix-otel-server branch November 23, 2024 01:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants