Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[jaeger-v2] Add HotROD integration test for jaeger-v2 #6138

Merged

Conversation

Saumya40-codes
Copy link
Contributor

@Saumya40-codes Saumya40-codes commented Oct 29, 2024

Which problem is this PR solving?

Description of the changes

  • Currently in .github/workflows/ci-docker-hotrod.yml, we are only testing internally via .scripts/build-hotrod-image.sh for examples/hotrod/docker-compose.yml while examples/hotrod/docker-compose-v2.yml isnt getting covered

  • For this, in .github/workflows/ci-docker-hotrod.yml we are passing -v flag to specify the jaeger version (v1 or v2)

How was this change tested?

  • For the flags and normal bash scirpt code i tested it manually in seperate bash file so that atleast ensures the basic code test

Checklist

Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
@Saumya40-codes Saumya40-codes changed the title Hotrod intergration test for v1v2 [jaeger-v2] Add HotROD integration test for jaeger-v2 Oct 29, 2024
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (c5f34d9) to head (69541a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6138      +/-   ##
==========================================
- Coverage   96.42%   96.39%   -0.03%     
==========================================
  Files         353      353              
  Lines       20141    20141              
==========================================
- Hits        19420    19414       -6     
- Misses        534      540       +6     
  Partials      187      187              
Flag Coverage Δ
badger_v1 ?
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.52% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.61% <ø> (ø)
elasticsearch-8.x-v1 18.78% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <ø> (-0.02%) ⬇️
grpc_v1 9.50% <ø> (ø)
grpc_v2 7.01% <ø> (+<0.01%) ⬆️
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.68% <ø> (ø)
opensearch-1.x-v1 18.66% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.66% <ø> (ø)
opensearch-2.x-v2 1.68% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
@Saumya40-codes
Copy link
Contributor Author

v2 test passes now, though i'd one doubt regarding execution which i'll just left in comments

@Saumya40-codes Saumya40-codes marked this pull request as ready for review October 29, 2024 18:30
@Saumya40-codes Saumya40-codes requested a review from a team as a code owner October 29, 2024 18:30
@dosubot dosubot bot added the v2 label Oct 29, 2024
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
@yurishkuro yurishkuro merged commit 2d74619 into jaegertracing:main Oct 30, 2024
50 checks passed
@yurishkuro
Copy link
Member

Thanks!

@Saumya40-codes Saumya40-codes deleted the hotrod-intergration-test-for-v1v2 branch October 31, 2024 06:47
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HotROD integration test for jaeger-v2
2 participants