-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[jaeger-v2] Add HotROD integration test for jaeger-v2 #6138
Merged
yurishkuro
merged 11 commits into
jaegertracing:main
from
Saumya40-codes:hotrod-intergration-test-for-v1v2
Oct 30, 2024
Merged
[jaeger-v2] Add HotROD integration test for jaeger-v2 #6138
yurishkuro
merged 11 commits into
jaegertracing:main
from
Saumya40-codes:hotrod-intergration-test-for-v1v2
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6138 +/- ##
==========================================
- Coverage 96.42% 96.39% -0.03%
==========================================
Files 353 353
Lines 20141 20141
==========================================
- Hits 19420 19414 -6
- Misses 534 540 +6
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Saumya40-codes
commented
Oct 29, 2024
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
v2 test passes now, though i'd one doubt regarding execution which i'll just left in comments |
Saumya40-codes
commented
Oct 29, 2024
yurishkuro
reviewed
Oct 30, 2024
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
yurishkuro
reviewed
Oct 30, 2024
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
…m/Saumya40-codes/jaeger into hotrod-intergration-test-for-v1v2
yurishkuro
approved these changes
Oct 30, 2024
Thanks! |
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
…tracing#6138)" This reverts commit 2d74619.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Currently in
.github/workflows/ci-docker-hotrod.yml
, we are only testing internally via.scripts/build-hotrod-image.sh
forexamples/hotrod/docker-compose.yml
whileexamples/hotrod/docker-compose-v2.yml
isnt getting coveredFor this, in
.github/workflows/ci-docker-hotrod.yml
we are passing-v
flag to specify the jaeger version (v1
orv2
)How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test