chore: enable all rules of perfsprint linter #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 354 354
Lines 20126 20126
=======================================
Hits 19417 19417
Misses 524 524
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Nov 7, 2024
| @@ -138,11 +139,11 @@ func (e *bridgeFieldEncoder) AddTime(key string, value time.Time) { | |||
| } | |||
|
|
|||
| func (e *bridgeFieldEncoder) AddUint(key string, value uint) { | |||
| e.pairs = append(e.pairs, attribute.String(key, fmt.Sprintf("%d", value))) | |||
| e.pairs = append(e.pairs, attribute.String(key, strconv.FormatUint(uint64(value), 10))) | |||
There was a problem hiding this comment.
This is more performant
yurishkuro
reviewed
Nov 7, 2024
| } | ||
|
|
||
| func (e *bridgeFieldEncoder) AddUint64(key string, value uint64) { | ||
| e.pairs = append(e.pairs, attribute.String(key, fmt.Sprintf("%d", value))) | ||
| e.pairs = append(e.pairs, attribute.String(key, strconv.FormatUint(value, 10))) |
There was a problem hiding this comment.
this looks way uglier than sprintf
There was a problem hiding this comment.
I understand, this is more performant
yurishkuro
approved these changes
Nov 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test