Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auto-generate gogo annotations for api_v3 #6233

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 21, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.45%. Comparing base (48cf1ba) to head (fd14052).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/query/app/apiv3/grpc_handler.go 63.63% 2 Missing and 2 partials ⚠️
cmd/query/app/internal/api_v3/traces.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6233      +/-   ##
==========================================
- Coverage   96.45%   96.45%   -0.01%     
==========================================
  Files         355      355              
  Lines       20157    20151       -6     
==========================================
- Hits        19442    19436       -6     
  Misses        528      528              
  Partials      187      187              
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (ø)
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.36% <65.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro added a commit to jaegertracing/jaeger-idl that referenced this pull request Nov 21, 2024
## Which problem is this PR solving?
- Part of jaegertracing/jaeger#4150
- Having gogo annotations in the IDL makes it difficult to users to
build clients

## Description of the changes
- Remove gogo annotations
- Rename num_traces to search_depth

## How was this change tested?
- Tested in jaegertracing/jaeger#6233

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro and others added 5 commits November 20, 2024 21:40
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@rim99 rim99 mentioned this pull request Nov 21, 2024
@rim99
Copy link
Contributor

rim99 commented Nov 21, 2024

Test this change in this draft PR: #6237
PS. Please check description of that, this PR might need to be improved a little bit.

BTW, moving gogoproto related lines out is a great idea, since original proto file could be used by other programming languages .

Also, could you merge this first? Then I would rebase my PR: #6159

@yurishkuro
Copy link
Member Author

@rim99 please approve this change and I will merge it.

@rim99
Copy link
Contributor

rim99 commented Nov 21, 2024

@yurishkuro woud you like to regenerate file cmd/query/app/internal/api_v3/query_service.pb.go after idl renaming num_traces -> search_depth? Or it will be handled by some automated flows?

Because to manage all test passed, I had to make this change:

d6eeed8#diff-9f4e53eb6033f5e7d7af97a3fd7328e26bd3e5e948e01276cb85b3abfc0b2432

Copy link
Contributor

@rim99 rim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, I think that change might be related to my changes

@yurishkuro yurishkuro merged commit c00931f into jaegertracing:main Nov 21, 2024
51 of 52 checks passed
@yurishkuro yurishkuro deleted the apiv3-update branch November 21, 2024 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants