Enable get-return lint

[Rohanraj123]

Which problem is this PR solving?

#5506

Description of the changes

• Changed functions name get prefix -> extract prefix to bypass the linter

How was this change tested?

• make lint ``make test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

Sorry, the changes make no sense to me - why would we rename our business methods that match the naming in the external API? It's counterproductive.

[Rohanraj123]

Sorry, the changes make no sense to me - why would we rename our business methods that match the naming in the external API? It's counterproductive.

Can splitting the method into two such as :

`func (h *HTTPGateway) getServices(w http.ResponseWriter, r *http.Request) {
	services, err := h.QueryService.GetServices(r.Context())
	if h.tryHandleError(w, err, http.StatusInternalServerError) {
		return
	}
	h.marshalResponse(&api_v3.GetServicesResponse{
		Services: services,
	}, w)
}

`

can be converted into :

`func (h *HTTPGateway) getServices(ctx context.Context) ([]Service, error) {
	return h.QueryService.GetServices(ctx)
}

func (h *HTTPGateway) handleGetServices(w http.ResponseWriter, r *http.Request) {
	services, err := h.getServices(r.Context())
	if h.tryHandleError(w, err, http.StatusInternalServerError) {
		return
	}
	h.marshalResponse(&api_v3.GetServicesResponse{
		Services: services,
	}, w)
}
`

Would this approach work ? Suggestions?

[yurishkuro]

Discussing approaches means there is a problem to be solved. I don't see a problem with our code structure. Not every linter needs to be turned on.

[Rohanraj123]

make sense, I close the PR.