Return errors from span processor creation #6488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
==========================================
- Coverage 96.30% 96.25% -0.06%
==========================================
Files 372 372
Lines 21277 21282 +5
==========================================
- Hits 20491 20485 -6
- Misses 601 609 +8
- Partials 185 188 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
mahadzaryab1
reviewed
Jan 6, 2025
| @@ -36,7 +36,7 @@ type SpanHandlers struct { | |||
| } | |||
|
|
|||
| // BuildSpanProcessor builds the span processor to be used with the handlers | |||
| func (b *SpanHandlerBuilder) BuildSpanProcessor(additional ...ProcessSpan) processor.SpanProcessor { | |||
| func (b *SpanHandlerBuilder) BuildSpanProcessor(additional ...ProcessSpan) (processor.SpanProcessor, error) { | |||
There was a problem hiding this comment.
@yurishkuro why are we adding error to the signature here if this function isn't returning an error? is there going to be a follow-up PR?
There was a problem hiding this comment.
yes - as explained in the PR description, introducing OTEL components will introduce errors
mahadzaryab1
approved these changes
Jan 6, 2025
adityachopra29
pushed a commit
to adityachopra29/jaeger
that referenced
this pull request
Jan 9, 2025
## Which problem is this PR solving? - Part of jaegertracing#6487 ## Description of the changes - Creation of exporterhelper may result in an error, so extend the processor construction signature to return the error. ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: adityachopra29 <adityachopra2912@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?