Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[refactor] Move sampling strategy interfaces to internal/sampling/strategy #6547

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

ary82
Copy link
Contributor

@ary82 ary82 commented Jan 14, 2025

Which problem is this PR solving?

Description of the changes

  • Move sampling strategy interfaces from cmd/collector/app/sampling/samplingstrategy to internal/sampling/strategy

How was this change tested?

  • Covered by existing

Checklist

…tegy

Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@ary82 ary82 requested a review from a team as a code owner January 14, 2025 20:50
@ary82 ary82 requested a review from jkowall January 14, 2025 20:50
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (cec5ae1) to head (35fc20c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6547      +/-   ##
==========================================
+ Coverage   96.21%   96.22%   +0.01%     
==========================================
  Files         372      372              
  Lines       21363    21363              
==========================================
+ Hits        20554    20557       +3     
+ Misses        616      614       -2     
+ Partials      193      192       -1     
Flag Coverage Δ
badger_v1 10.65% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.55% <ø> (ø)
cassandra-4.x-v2-auto 2.71% <ø> (ø)
cassandra-4.x-v2-manual 2.71% <ø> (ø)
cassandra-5.x-v1-manual 16.55% <ø> (ø)
cassandra-5.x-v2-auto 2.71% <ø> (ø)
cassandra-5.x-v2-manual 2.71% <ø> (ø)
elasticsearch-6.x-v1 20.34% <ø> (ø)
elasticsearch-7.x-v1 20.40% <ø> (ø)
elasticsearch-8.x-v1 20.57% <ø> (ø)
elasticsearch-8.x-v2 2.77% <ø> (ø)
grpc_v1 12.17% <ø> (ø)
grpc_v2 9.04% <ø> (+<0.01%) ⬆️
kafka-3.x-v1 10.33% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.77% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 20.45% <ø> (ø)
opensearch-2.x-v1 20.46% <ø> (ø)
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.10% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ary82 added 2 commits January 15, 2025 21:22
…lingstrategy

Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@yurishkuro yurishkuro enabled auto-merge (squash) January 15, 2025 17:12
@yurishkuro yurishkuro disabled auto-merge January 15, 2025 17:13
@yurishkuro yurishkuro merged commit d1d9ced into jaegertracing:main Jan 15, 2025
52 of 53 checks passed
@ary82 ary82 deleted the refactor-sampling-strategy branch January 15, 2025 17:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants