Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add REPLICATION parameter to Cassandra schema script #6582

Merged

Conversation

asimchoudhary
Copy link
Contributor

@asimchoudhary asimchoudhary commented Jan 21, 2025

Which problem is this PR solving?

Resolves #2618

Description of the changes

  • The addition of the REPLICATION variable allows users to directly specify a custom replication configuration for Cassandra, overriding the default behavior.

How was this change tested?

  • i used the make test command provided by the jaeger

Checklist

…ti datacenter support

Signed-off-by: asim <aktech701@gmail.com>
@asimchoudhary asimchoudhary requested a review from a team as a code owner January 21, 2025 16:56
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create unit tests for this script? Example scripts/utils/compute-tags.test.sh

@asimchoudhary
Copy link
Contributor Author

On it !

Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro changed the title add REPLICATION parameter to Cassandra schema Add REPLICATION parameter to Cassandra schema script Jan 22, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 22, 2025 18:40
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (b689a86) to head (c342eec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6582      +/-   ##
==========================================
+ Coverage   96.24%   96.25%   +0.01%     
==========================================
  Files         375      375              
  Lines       21397    21397              
==========================================
+ Hits        20593    20596       +3     
+ Misses        612      610       -2     
+ Partials      192      191       -1     
Flag Coverage Δ
badger_v1 10.63% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.64% <ø> (ø)
cassandra-4.x-v2-auto 2.72% <ø> (ø)
cassandra-4.x-v2-manual 2.72% <ø> (ø)
cassandra-5.x-v1-manual 16.64% <ø> (ø)
cassandra-5.x-v2-auto 2.72% <ø> (ø)
cassandra-5.x-v2-manual 2.72% <ø> (ø)
elasticsearch-6.x-v1 20.44% <ø> (ø)
elasticsearch-7.x-v1 20.50% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 20.66% <ø> (ø)
elasticsearch-8.x-v2 2.77% <ø> (ø)
grpc_v1 12.19% <ø> (-0.01%) ⬇️
grpc_v2 9.06% <ø> (+<0.01%) ⬆️
kafka-3.x-v1 10.36% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.78% <ø> (ø)
opensearch-1.x-v1 20.56% <ø> (ø)
opensearch-2.x-v1 20.55% <ø> (ø)
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 3222e01 into jaegertracing:main Jan 22, 2025
56 checks passed
yurishkuro pushed a commit that referenced this pull request Jan 25, 2025
## Which problem is this PR solving?
- Subpart of the #6582 

## Description of the changes
- created unit tests for the create.sh file , to test for various cases
such as presence of Mode parameter , output for specific parameters

## How was this change tested?
- 

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [X] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: asim <aktech701@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide multiple datacenters to Cassandra Schema generation scripts
2 participants