-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use jeager-idl/proto-gen/api_v2 #6609
Use jeager-idl/proto-gen/api_v2 #6609
Conversation
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6609 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 364 364
Lines 20750 20750
=======================================
Hits 19932 19932
Misses 622 622
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hello @yurishkuro make sure to look at this
|
can we add a linter rule similar to #6610 ? |
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
d1388a7
to
ebf26ff
Compare
Which problem is this PR solving?
Description of the changes
How was this change tested?
make test
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test