Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use jeager-idl/proto-gen/api_v2 #6609

Merged

Conversation

Nabil-Salah
Copy link
Contributor

@Nabil-Salah Nabil-Salah commented Jan 25, 2025

Which problem is this PR solving?

Description of the changes

  • replace model proto-gen_api_v2 imports to use jaeger-idl proto-gen/api_v2 imports
  • Prohibit dependencies on github.com/jaegertracing/jaeger/proto-gen/api_v2 via linter

How was this change tested?

  • make test

Checklist

Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah Nabil-Salah requested a review from a team as a code owner January 25, 2025 16:35
@dosubot dosubot bot added the v2 label Jan 25, 2025
@Nabil-Salah Nabil-Salah changed the title feat: use jeager-idl/proto-gen/api_v2 Use jeager-idl/proto-gen/api_v2 Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (7168853) to head (d1388a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6609   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         364      364           
  Lines       20750    20750           
=======================================
  Hits        19932    19932           
  Misses        622      622           
  Partials      196      196           
Flag Coverage Δ
badger_v1 9.88% <ø> (ø)
badger_v2 1.83% <ø> (ø)
cassandra-4.x-v1-manual 15.02% <ø> (ø)
cassandra-4.x-v2-auto 1.82% <ø> (ø)
cassandra-4.x-v2-manual 1.82% <ø> (ø)
cassandra-5.x-v1-manual 15.02% <ø> (ø)
cassandra-5.x-v2-auto 1.82% <ø> (ø)
cassandra-5.x-v2-manual 1.82% <ø> (ø)
elasticsearch-6.x-v1 19.23% <ø> (ø)
elasticsearch-7.x-v1 19.31% <ø> (ø)
elasticsearch-8.x-v1 19.48% <ø> (ø)
elasticsearch-8.x-v2 1.83% <ø> (ø)
grpc_v1 11.18% <ø> (ø)
grpc_v2 8.04% <ø> (ø)
kafka-3.x-v1 10.17% <ø> (ø)
kafka-3.x-v2 1.83% <ø> (ø)
memory_v2 1.83% <ø> (ø)
opensearch-1.x-v1 19.36% <ø> (ø)
opensearch-2.x-v1 19.36% <ø> (ø)
opensearch-2.x-v2 1.83% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nabil-Salah
Copy link
Contributor Author

hello @yurishkuro
i think i forgot to find/replace proto-gen/api_v2 so can we do in this pr ;D

make sure to look at this

  • scripts/lint/import-order-cleanup.py

@yurishkuro
Copy link
Member

can we add a linter rule similar to #6610 ?

@Nabil-Salah Nabil-Salah force-pushed the use_jaegeridl_proto-gen_api_v2 branch from d1388a7 to ebf26ff Compare January 25, 2025 20:34
@yurishkuro yurishkuro enabled auto-merge (squash) January 25, 2025 21:39
@yurishkuro yurishkuro merged commit 6d4d7c4 into jaegertracing:main Jan 25, 2025
104 of 107 checks passed
@Nabil-Salah Nabil-Salah deleted the use_jaegeridl_proto-gen_api_v2 branch January 25, 2025 22:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants