Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alias samping.thrift and clean thrift files #6630

Merged
merged 10 commits into from
Jan 29, 2025
3 changes: 0 additions & 3 deletions .github/workflows/ci-lint-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ jobs:
- name: Verify Protobuf types are up to date
run: make proto && { if git status --porcelain | grep '??'; then exit 1; else git diff --name-status --exit-code; fi }

- name: Verify Thrift types are up to date
run: make thrift && { if git status --porcelain | grep '??'; then exit 1; else git diff --name-status --exit-code; fi }

- name: Verify Mockery types are up to date
run: make generate-mocks && { if git status --porcelain | grep '??'; then exit 1; else git diff --name-status --exit-code; fi }

Expand Down
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ ALL_SRC = $(shell find . -name '*.go' \
-not -path './internal/tools/*' \
-not -path './docker/debug/*' \
-not -path '*/mocks/*' \
-not -path '*/*-gen/*' \
-not -path '*/thrift-0.9.2/*' \
-type f | \
sort)
Expand All @@ -47,7 +46,7 @@ SCRIPTS_SRC = $(shell find . \( -name '*.sh' -o -name '*.py' -o -name '*.mk' -o
sort)

# ALL_PKGS is used with 'nocover' and 'goleak'
ALL_PKGS = $(shell echo $(dir $(ALL_SRC)) | tr ' ' '\n' | sort -u)
ALL_PKGS = $(shell echo $(dir $(ALL_SRC)) | tr ' ' '\n' | grep -v '/.*-gen/' | sort -u)

GO=go
GOOS ?= $(shell $(GO) env GOOS)
Expand Down Expand Up @@ -82,7 +81,6 @@ include Makefile.Crossdock.mk
include Makefile.Docker.mk
include Makefile.IntegrationTests.mk
include Makefile.Protobuf.mk
include Makefile.Thrift.mk
include Makefile.Tools.mk
include Makefile.Windows.mk

Expand Down
22 changes: 0 additions & 22 deletions Makefile.Thrift.mk

This file was deleted.

2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ require (
github.com/hashicorp/hcl v1.0.0 // indirect
github.com/iancoleman/strcase v0.3.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/jaegertracing/jaeger-idl v0.0.0-20250127031220-68c7c1836e84
github.com/jaegertracing/jaeger-idl v0.0.0-20250129145848-5fa35ae945ef
github.com/jcmturner/aescts/v2 v2.0.0 // indirect
github.com/jcmturner/dnsutils/v2 v2.0.0 // indirect
github.com/jcmturner/gofork v1.7.6 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,8 @@ github.com/ionos-cloud/sdk-go/v6 v6.1.11 h1:J/uRN4UWO3wCyGOeDdMKv8LWRzKu6UIkLEae
github.com/ionos-cloud/sdk-go/v6 v6.1.11/go.mod h1:EzEgRIDxBELvfoa/uBN0kOQaqovLjUWEB7iW4/Q+t4k=
github.com/jaegertracing/jaeger-idl v0.0.0-20250127031220-68c7c1836e84 h1:yku1F14QLYpYA0kVx+DMcUXcOoS4vtYeSBka4eXR7u4=
github.com/jaegertracing/jaeger-idl v0.0.0-20250127031220-68c7c1836e84/go.mod h1:okucign90cUWvkXRY3OVBKZKWStz5EokIPMPxirt3nk=
github.com/jaegertracing/jaeger-idl v0.0.0-20250129145848-5fa35ae945ef h1:LyDmrGCt+QGBneOIQmixXdGLKEOjJmcgBELJITpJ+ak=
github.com/jaegertracing/jaeger-idl v0.0.0-20250129145848-5fa35ae945ef/go.mod h1:okucign90cUWvkXRY3OVBKZKWStz5EokIPMPxirt3nk=
github.com/jcmturner/aescts/v2 v2.0.0 h1:9YKLH6ey7H4eDBXW8khjYslgyqG2xZikXP0EQFKrle8=
github.com/jcmturner/aescts/v2 v2.0.0/go.mod h1:AiaICIRyfYg35RUkr8yESTqvSy7csK90qZ5xfvvsoNs=
github.com/jcmturner/dnsutils/v2 v2.0.0 h1:lltnkeZGL0wILNvrNiVCR6Ro5PGU/SeBvVO/8c/iPbo=
Expand Down
2 changes: 1 addition & 1 deletion model/converter/json/sampling_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"github.com/stretchr/testify/require"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
api_v1 "github.com/jaegertracing/jaeger-idl/thrift-gen/sampling"
thriftconv "github.com/jaegertracing/jaeger/model/converter/thrift/jaeger"
api_v1 "github.com/jaegertracing/jaeger/thrift-gen/sampling"
)

func TestSamplingStrategyResponseToJSON_Error(t *testing.T) {
Expand Down
3 changes: 3 additions & 0 deletions proto-gen/api_v2/collector.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package api_v2

import (
Expand Down
3 changes: 3 additions & 0 deletions proto-gen/api_v2/query.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package api_v2

import (
Expand Down
3 changes: 3 additions & 0 deletions proto-gen/api_v2/sampling.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package api_v2

import (
Expand Down
19 changes: 14 additions & 5 deletions thrift-gen/agent/agent.go
Original file line number Diff line number Diff line change
@@ -1,21 +1,30 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package agent

import (
modelv1 "github.com/jaegertracing/jaeger-idl/thrift-gen/agent"
modelv1 "github.com/jaegertracing/jaeger-idl/thrift-gen/agent"
)

type Agent = modelv1.Agent

type AgentClient = modelv1.AgentClient
var NewAgentClientFactory = modelv1.NewAgentClientFactory
var NewAgentClientProtocol = modelv1.NewAgentClientProtocol
var NewAgentClient = modelv1.NewAgentClient

var (
NewAgentClientFactory = modelv1.NewAgentClientFactory
NewAgentClientProtocol = modelv1.NewAgentClientProtocol
NewAgentClient = modelv1.NewAgentClient
)

type AgentProcessor = modelv1.AgentProcessor

var NewAgentProcessor = modelv1.NewAgentProcessor

type AgentEmitZipkinBatchArgs = modelv1.AgentEmitZipkinBatchArgs

var NewAgentEmitZipkinBatchArgs = modelv1.NewAgentEmitZipkinBatchArgs

type AgentEmitBatchArgs = modelv1.AgentEmitBatchArgs
var NewAgentEmitBatchArgs = modelv1.NewAgentEmitBatchArgs

var NewAgentEmitBatchArgs = modelv1.NewAgentEmitBatchArgs
6 changes: 0 additions & 6 deletions thrift-gen/baggage/GoUnusedProtection__.go

This file was deleted.

30 changes: 0 additions & 30 deletions thrift-gen/baggage/baggage-consts.go

This file was deleted.

Loading
Loading