Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update import paths for jaeger thrift files to use jaeger-idl #6635

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Nabil-Salah
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • replace use of jaeger-idl/thrift-gen/sampling imports

How was this change tested?

  • `make test lint'

Checklist

Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah Nabil-Salah requested a review from a team as a code owner January 30, 2025 15:31
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (17cdd33) to head (ac844ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6635      +/-   ##
==========================================
- Coverage   95.94%   95.90%   -0.04%     
==========================================
  Files         365      365              
  Lines       20609    20609              
==========================================
- Hits        19774    19766       -8     
- Misses        636      642       +6     
- Partials      199      201       +2     
Flag Coverage Δ
badger_v1 9.91% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 14.92% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 14.92% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.55% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (ø)
grpc_v1 10.89% <ø> (ø)
grpc_v2 7.88% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.43% <ø> (ø)
opensearch-2.x-v1 19.43% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.79% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nabil-Salah Nabil-Salah changed the title fix: update import paths for jaeger thrift files to use jaeger-idl Update import paths for jaeger thrift files to use jaeger-idl Jan 30, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 30, 2025 16:51
@yurishkuro yurishkuro merged commit 6d8c70e into jaegertracing:main Jan 30, 2025
55 of 57 checks passed
@yurishkuro
Copy link
Member

Thanks!

@Nabil-Salah Nabil-Salah deleted the use_sampling_jaeger_idl branch January 30, 2025 16:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants