Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use UTC for model timezone #712

Merged
merged 2 commits into from
Feb 25, 2018
Merged

Use UTC for model timezone #712

merged 2 commits into from
Feb 25, 2018

Conversation

vprithvi
Copy link
Contributor

@vprithvi vprithvi commented Feb 23, 2018 •
edited
Loading

  • standardize on UTC for time representation
  • the wire format for everything is microseconds since epoch, so this change does not effect data transfer over rpcs.

Signed-off-by: Prithvi Raj p.r@uber.com

@vprithvi
Use UTC for model timezone
f887310 
- standardize on UTC for time representation

Signed-off-by: Prithvi Raj <p.r@uber.com>
@ghost ghost assigned vprithvi Feb 23, 2018
@ghost ghost added the review label Feb 23, 2018
@black-adder
Copy link
Contributor

I'm ok with this but why?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 716c957 on use-utc-model into e2f1150 on master.

@yurishkuro yurishkuro merged commit d59f917 into master Feb 25, 2018
@ghost ghost removed the review label Feb 25, 2018
@vprithvi vprithvi deleted the use-utc-model branch August 22, 2018 16:44
@plajjan plajjan mentioned this pull request Jul 2, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees

@vprithvi vprithvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vprithvi @black-adder @coveralls @yurishkuro