Log errors from HotROD servers #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned 
isaachier
reviewed
Apr 10, 2018
| server := driver.NewServer( | ||
| net.JoinHostPort(driverOptions.serverInterface, strconv.Itoa(driverOptions.serverPort)), | ||
| tracing.Init("driver", metricsFactory.Namespace("driver", nil), logger, jAgentHostPort), | ||
| metricsFactory, | ||
| logger, | ||
| jAgentHostPort, | ||
| ) | ||
| return server.Run() | ||
| return logError(zapLogger, server.Run()) |
There was a problem hiding this comment.
Is it worth logging here and returning the same error? Will this lead to duplicate logs up the call stack? Maybe wrapping within another error makes more sense.
There was a problem hiding this comment.
it does lead to dup logs, but that's better than not getting logs at all, which would be the case since the all command calls all servers except frontend via go ..., so returned errors go nowhere.
There was a problem hiding this comment.
Right. I meant we could improve the code to wrap the errors each time, but this is all sample code so I don't really mind.
black-adder
approved these changes
Apr 10, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuri Shkuro ys@uber.com