Close span writer in standalone #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
jpkrohling,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
black-adder
reviewed
Jun 8, 2018
| @@ -130,6 +131,13 @@ func main() { | |||
|
|
|||
| select { | |||
| case <-signalsChannel: | |||
| if closer, ok := spanWriter.(io.Closer); ok { | |||
There was a problem hiding this comment.
what about spanReader, dependencyReader, etc. might be easier to register everything that implements the io.Closer interface during initialization and iterate over them and close them
There was a problem hiding this comment.
readers don't implement closer. This is just port from collector main.
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 121
Lines ? 5991
Branches ? 0
=======================================
Hits ? 5991
Misses ? 0
Partials ? 0Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Jun 11, 2018
mabn
pushed a commit
to mabn/jaeger
that referenced
this pull request
Jun 13, 2018
* master: Add back quotes Adding CONTRIBUTING_GUIDELINES.md (jaegertracing#864) Close span writer in standalone (jaegertracing#863) Fix Process IP problem/inconsistency (jaegertracing#821) (jaegertracing#865) Use NewSpanID()/NewTraceID() instead of type-specific intializations (jaegertracing#861) Do not create duplicate child-of reference from parentSpanId (jaegertracing#860) Switch to codecov (jaegertracing#857) Log configuration options for memory storage (jaegertracing#852) Add jpkrohling to maintainers / code owners (jaegertracing#851)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com